Convert to Java 1.8 only.#7
Open
samskivert wants to merge 5 commits intomasterfrom
Open
Conversation
- Changes the Listener abstract classes into interfaces with default methods. - Isolates SignalView.Listener from ValueView.Listener and makes Slot into a functional interface that works for both. - Eliminates Functions because that can be done with lambdas more concisely than the Functions helpers. - Moves Slots statics into Slot since interfaces can have static methods now. - Eliminates UnitSlot as it's easy enough to have an ignored parameter in a lambda (and Java 9/10 will allow use of _ parameter). UnitSignal becomes Signal.Unit to reduce top-level namespace names. - Removes various methods/helpers that existed only to save boilerplate which is now better accomplished via lambdas and/or bound methods. RPromise.completer, for example, which can now be expressed as p::complete. - Moves Closeable.Util helpers into Closeable because we can have static members of interfaces now.
Android requires API 24 for the java.util.function package and RoboVM doesn't include it at all. We'll have to forgo that particular slice of the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the Listener abstract classes into interfaces with default methods.
Isolates SignalView.Listener from ValueView.Listener and makes Slot into a
functional interface that works for both.
Eliminates Functions because that can be done with lambdas more concisely
than the Functions helpers.
Moves Slots statics into Slot since interfaces can have static methods now.
Eliminates UnitSlot as it's easy enough to have an ignored parameter in a
lambda (and Java 9/10 will allow use of _ parameter). UnitSignal becomes
Signal.Unit to reduce top-level namespace names.
Removes various methods/helpers that existed only to save boilerplate which
is now better accomplished via lambdas and/or bound methods.
RPromise.completer, for example, which can now be expressed as p::complete.
Moves Closeable.Util helpers into Closeable because we can have static
members of interfaces now.