Improve yt-dlp video format presentation - #51
Conversation
# Conflicts: # Harbor/Services/MediaDownloadService.swift # Harbor/ViewModels/DownloadCenter.swift
|
@QZGao I think keeping the toggle defaults to ON is good for now. I'll think of better UI for whole add download sheet. |
thsnkhn
left a comment
There was a problem hiding this comment.
Left a few thoughts inline. The exact format work is useful — I think we can keep it while making the routing a bit simpler and preserving the media types Harbor already supports.
|
I just asked Codex to do a code review and found several issues.
|
I am working on fixing each of the issues identified. |
|
Okay, the aforementioned issues have been fixed. |
|
I liked your designs. let me take a pull to test it out |
Side note: Currently Harbor's bundled yt-dlp (P.S. This issue hardly matters anyway. Few people would want to download those AI slop dubs so we can just call it day and wait for the next yt-dlp stable release.) |
|
im gonna merge it now. will use the app to see overall UX, improve if needed otherwise will be releasing it. thanks for your efforts |




When implementing #50, I found that the yt-dlp pipeline is not very intuitive. Therefore this PR works on its features and presentation.
Changelist
Improve yt-dlp eligibility validation using checked format metadata instead of file extensions, extractor names, or known-host assumptions.
--check-all-formats.Improve presentation for yt-dlp downloads:
Best MP4preference toOriginal. Default every media download toOriginal.137+140to yt-dlp without silently falling back to another format.Fixes several bugs:
Verification: built and tested locally.
I did not implement #40; currently the toggle defaults to OFF. If you prefer, we can set the default to ON -- or if you are a different idea on how to address it.