Idle time, connection TTL and other features - #52
Open
droscy wants to merge 13 commits into
Open
Conversation
tiagocoutinho
self-requested a review
November 13, 2025 07:32
tiagocoutinho
requested changes
Nov 18, 2025
Author
Sure, as soon as I can study your test framework I'll add some test cases. |
Author
|
I've added some tests for the new parameters. All these tests are based on the I've also added myself among contributors; other contributors are present in git history but I left the decision to you to add them to the readme file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I started receiving invalid data from inverter after a firmware upgrade and so I added to modbus-proxy some features in order to diagnose and bypass inconsistent reading.
These are the new parameters I've added:
idle_time: how many seconds to wait before closing an idle connection to the modbus deviceconnection_ttl: max duration of a connection, in seconds, to the modbus devicereconnect_delay: how many seconds to wait before establishing a new connection to the modbus device after an errorrequest_delay: how many seconds to wait between two requests