Default Symphony concurrency to five workers#3
Conversation
The previous global default of ten concurrent agents was too aggressive for the expected out-of-the-box operating profile. Lower the runtime schema, installer-generated custom and symphony-dev profiles, local workflow contract, and dashboard snapshots to five while leaving explicitly conservative starter profiles at one worker. Constraint: Starter and review-gated onboarding profiles intentionally remain at one concurrent agent for first production-like runs Rejected: Only change elixir/WORKFLOW.md | generated and schema-default workflows would still produce ten workers Confidence: high Scope-risk: narrow Tested: make -C elixir all Tested: mix test test/symphony_elixir/workspace_and_config_test.exs:722 test/symphony_elixir/installer_apply_test.exs:45 Tested: UPDATE_SNAPSHOTS=1 mix test test/symphony_elixir/status_dashboard_snapshot_test.exs Co-authored-by: Codex <codex@openai.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe default maximum concurrent agents limit is reduced from 10 to 5 across the codebase, including configuration schemas, workflow profiles, documentation, and corresponding test fixtures and expectations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 55 minutes and 10 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@SPEC.md`:
- Line 586: The SPEC currently has conflicting defaults for
agent.max_concurrent_agents (Line 586 shows default 5 while Section 5.3.5 shows
default 10); update the document so both occurrences state the same default
value—pick the correct intended default (e.g., 10 or 5) and change the other
occurrence to match; search for the symbol "agent.max_concurrent_agents" and
edit every mention (including the entry at Line 586 and the Section 5.3.5
description) so the default value is consistent across the SPEC.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8a1a6d30-5c59-4a64-82ac-1436b48f90b0
📒 Files selected for processing (17)
SPEC.mdelixir/WORKFLOW.mdelixir/lib/symphony_elixir/config/schema.exelixir/lib/symphony_elixir/installer/workflow_profile.exelixir/test/fixtures/status_dashboard_snapshots/backoff_queue.evidence.mdelixir/test/fixtures/status_dashboard_snapshots/backoff_queue.snapshot.txtelixir/test/fixtures/status_dashboard_snapshots/credits_unlimited.evidence.mdelixir/test/fixtures/status_dashboard_snapshots/credits_unlimited.snapshot.txtelixir/test/fixtures/status_dashboard_snapshots/idle.evidence.mdelixir/test/fixtures/status_dashboard_snapshots/idle.snapshot.txtelixir/test/fixtures/status_dashboard_snapshots/idle_with_dashboard_url.evidence.mdelixir/test/fixtures/status_dashboard_snapshots/idle_with_dashboard_url.snapshot.txtelixir/test/fixtures/status_dashboard_snapshots/super_busy.evidence.mdelixir/test/fixtures/status_dashboard_snapshots/super_busy.snapshot.txtelixir/test/support/test_support.exselixir/test/symphony_elixir/installer_apply_test.exselixir/test/symphony_elixir/workspace_and_config_test.exs
The first concurrency-default commit updated the cheat sheet entry but missed the detailed `agent` section. Align both SPEC mentions on the intended five-agent default so the configuration contract has one answer. Constraint: CodeRabbit review found the stale second SPEC default before merge Confidence: high Scope-risk: narrow Tested: rg -n 'max_concurrent_agents.*default.*10|Default: `10`|default `10`' SPEC.md Co-authored-by: Codex <codex@openai.com>
|
[codex] Changes since last review:
|
Context
The out-of-the-box global concurrency default is currently ten agents, which is higher than the desired default operating posture for normal Symphony runs.
TL;DR
Default standard Symphony concurrency to five agents while keeping conservative onboarding profiles at one.
Summary
agent.max_concurrent_agentsdefault from10to5.symphony-devworkflow defaults to emit five agents./5.Alternatives
elixir/WORKFLOW.md; rejected because generated workflows and omitted config would still use ten.Test Plan
make -C elixir allmix test test/symphony_elixir/workspace_and_config_test.exs:722 test/symphony_elixir/installer_apply_test.exs:45UPDATE_SNAPSHOTS=1 mix test test/symphony_elixir/status_dashboard_snapshot_test.exs