feat(web): show machine label in session list#266
Draft
webwww123 wants to merge 1 commit intotiann:mainfrom
Draft
feat(web): show machine label in session list#266webwww123 wants to merge 1 commit intotiann:mainfrom
webwww123 wants to merge 1 commit intotiann:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #265.
When multiple machines are connected to the same hub, the session list is currently grouped only by directory, which makes sessions from different machines hard to distinguish.
This PR makes the web session list more multi-machine friendly by:
machine + directorydisplayName -> host -> short machineIdas the label fallback chainScope
Web-only change.
No hub, CLI, protocol, or database changes.
Why
A common real-world case is:
/root/rootWithout machine identity in the session list, those sessions are difficult to tell apart quickly.
Validation
Validated in an isolated Docker-based dev environment only.
Commands run:
cd web bunx vitest run src/components/SessionList.test.ts bun run typecheck