Skip to content

feat: add gemini yolo mode#280

Merged
tiann merged 1 commit intotiann:mainfrom
Next2012:dev_add_gemini_yolo
Mar 11, 2026
Merged

feat: add gemini yolo mode#280
tiann merged 1 commit intotiann:mainfrom
Next2012:dev_add_gemini_yolo

Conversation

@Next2012
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review mode: initial

Findings:

  • MAJOR: Safe-yolo mapped to --yolo in Gemini ACP; escalates permissions beyond Safe Yolo. See inline.

Testing: Not run (automation)

if (model) {
args.push('--model', model);
}
if (opts.permissionMode === 'yolo' || opts.permissionMode === 'safe-yolo') {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MAJOR] Safe-yolo currently maps to full --yolo, collapsing Safe Yolo into Yolo and bypassing intended safeguards. Suggest mapping safe-yolo to the same approval mode as local launcher (auto_edit) and reserving --yolo for yolo.

Suggested fix:

if (opts.permissionMode === 'safe-yolo') {
    args.push('--approval-mode', 'auto_edit');
} else if (opts.permissionMode === 'yolo') {
    args.push('--yolo');
}

@tiann tiann merged commit c730ad5 into tiann:main Mar 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants