Skip to content

fix: empty file list for initial commit - #177

Merged
tibirna merged 1 commit into
tibirna:masterfrom
vvch:fix_initial
Jul 14, 2026
Merged

fix: empty file list for initial commit#177
tibirna merged 1 commit into
tibirna:masterfrom
vvch:fix_initial

Conversation

@vvch

@vvch vvch commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

The file list for initial commit was always empty. This patch fixes the issue.

@tibirna
tibirna merged commit 04ebbf0 into tibirna:master Jul 14, 2026
2 checks passed
@tibirna

tibirna commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Excellent catch! I guess it was a remnant of early git releases without the --root option on diff-tree. Thank you!

@vvch

vvch commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Maybe you are right. --root option was introduced in 2005 even before git v1.0 whereas initial qgit import commit was in 2006 and it already had parentsCount() == 0 skip condition. But seems like it had been developed long before.

@vvch

vvch commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

No, I was confused :)
--root option was added on May 20 2005 but first git commit was on Apr 8 2005. That is git existed only 6 weeks without --root in diff-tree. It is a very little chance that qgit was developed in such a short period :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants