Bug-Fix: FRC Team Rank - Handle null qual data from The Blue Alliance API#3196
Open
dragid10 wants to merge 2 commits intotidbyt:mainfrom
Open
Bug-Fix: FRC Team Rank - Handle null qual data from The Blue Alliance API#3196dragid10 wants to merge 2 commits intotidbyt:mainfrom
dragid10 wants to merge 2 commits intotidbyt:mainfrom
Conversation
… API The Blue Alliance returns "qual": null when an event is active but matches haven't started yet. The existing checks only verified key existence, not whether the value was None, causing a crash on the `in` operator.
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Simplifies nested dict access for readability and safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"qual": nullwhen an event is active but qualification matches haven't started yetnot in), not whether the value wasNone, causing a crash on theinoperator== Nonechecks at each nesting level inget_team_ranking()so the app gracefully falls back to the default ranking message