Skip to content

Bug-Fix: FRC Team Rank - Handle null qual data from The Blue Alliance API#3196

Open
dragid10 wants to merge 2 commits intotidbyt:mainfrom
dragid10:fix/frc-team-rank-null-qual
Open

Bug-Fix: FRC Team Rank - Handle null qual data from The Blue Alliance API#3196
dragid10 wants to merge 2 commits intotidbyt:mainfrom
dragid10:fix/frc-team-rank-null-qual

Conversation

@dragid10
Copy link
Copy Markdown
Contributor

Summary

  • The Blue Alliance API returns "qual": null when an event is active but qualification matches haven't started yet
  • The existing null checks only verified key existence (not in), not whether the value was None, causing a crash on the in operator
  • Added == None checks at each nesting level in get_team_ranking() so the app gracefully falls back to the default ranking message

… API

The Blue Alliance returns "qual": null when an event is active but
matches haven't started yet. The existing checks only verified key
existence, not whether the value was None, causing a crash on the
`in` operator.
@tidbyt
Copy link
Copy Markdown

tidbyt Bot commented Mar 20, 2026

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

@dragid10
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Simplifies nested dict access for readability and safety.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant