Open
Conversation
Member
Author
|
I don't know if this is too much or not. It increases the complexity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
make_function_lists.Rscript into one script for each table corresponding to the tables seen on https://www.tidymodels.org/find/.make_function_lists.Rinto separate scripts inmake_function_lists/:_utils.R- shared utilities and caching logicbroom.R,recipes.R,tidymodels.R,parsnip.R,sparse.R,tidyclust.R- one for each tablerun_all.R- runs all of them (same as running make_function_list.R)I replace
pkgdown::as_pkgdown()with direct Rd file parsing viatools::parse_Rd().The more important change is the implementation of caching. We now store a cache of the things we are fetching in
.pkg_cache.csv. Reducing the total time taken to run all of this down to around 3 minutes.Notice we are still fetching things from websites, so this is still not static.