Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to tidymodels/orbital#109
This PR switches all tree-based models to generate nested
case_when()expressions instead of flat ones. Nested expressions mirror the tree structure, producing more efficient R and SQL code.Before (flat):
After (nested):
Changes
New features
case_when()expressionsvignettes/tree-internals.Rmd) explaining the nested approach and tree algorithmsparse_model()documentation now explains the version system (v1/v2/v3) and model type classesInternal improvements
apply_xgb_objective()andapply_lgb_objective()for objective transformationsapply_lgb_multiclass_transformation()andapply_catboost_multiclass_transformation()for multiclass handlingtree-nested.Rcase_when()builders preserved for backwards compatibility with parsed models saved using v1/v2 format