fix(deps): bump nested brace-expansion to 5.0.8 in client/web - #43
Merged
Merged
Conversation
The rimraf-scoped brace-expansion resolved to 5.0.7, which is vulnerable to unbounded expansion DoS (GHSA-mh99-v99m-4gvg). minimatch@10.2.5 accepts ^5.0.5, so 5.0.8 resolves without an override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Dependabot alert #73 (GHSA-mh99-v99m-4gvg, high): brace-expansion DoS via unbounded expansion length.
Why Dependabot could not do this
Dependabot's security update failed because it tries to satisfy one version across the whole tree, and two trees disagree:
@capacitor/cli->minimatch@10.2.5->brace-expansion@^5.0.5protobufjs-cli->minimatch@5.1.9->brace-expansion@^2.0.1Only the 5.x instance is flagged (alert #38 followed the same pattern: 5.0.6 -> 5.0.7).
minimatch@10.2.5accepts^5.0.5, so bumping the nested entry to 5.0.8 needs nooverridesand leaves the 2.x tree untouched.Change
Lockfile-only:
node_modules/rimraf/node_modules/brace-expansion5.0.7 -> 5.0.8 (dev scope).Verification
npm ciclean (integrity validated)npm test14/14 passednpm run build-nologsucceeded