refactor: migrate web client from TypeScript to JavaScript with JSDoc - #45
Merged
Merged
Conversation
Convert all .ts and <script lang="ts"> Svelte files under client/web to .js/.svelte with JSDoc type annotations, replacing tsconfig project references with a single jsconfig.json (strict + checkJs) and adding a svelte-check `check` script. No runtime behavior changes; a handful of pre-existing strictness gaps (missing vite/client ambient types, Phaser scene fields without initializers, a WebSocket ArrayBuffer generic mismatch) are annotated/cast rather than altered so the new check gate is green without changing logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the Svelte+Phaser web client (19 .ts files + 7 .svelte TS script blocks) to plain JavaScript with JSDoc. Three tsconfigs collapse into one strict checkJs jsconfig; new check script runs svelte-check against it (the old project-references root tsconfig silently swallowed 10+ real type errors — now annotated with zero-behavior casts and actually checked). Gates: svelte-check 0 errors/0 warnings (199 files), tests 14/14, build green. Repo was unarchived only for this migration and will be re-archived after merge.