fix(t4metric_v2): filter GT by annotation num_lidar_pts - #224
Open
vividf wants to merge 1 commit into
Open
Conversation
…computing from input points The min_num_points GT filter recomputed per-box point counts with points_in_rbbox on the model input point cloud (multi-sweep, after remove_close and range filtering). This couples the evaluation GT set to the input pipeline configuration: changing the sweep count or any point-cloud preprocessing changes which GT boxes are evaluated, so runs with different input configs are not comparable. Sweep accumulation is also not object-motion compensated, so the recomputed counts are physically wrong for moving objects. Use the annotation num_lidar_pts stored in the info pkl instead (keyframe count, the nuScenes/Waymo convention), which keeps the GT set a fixed property of the dataset. Verified on the j6gen2_base val split (3645 frames): the field is fully populated, and the filtered GT set now matches an independent implementation class by class. Signed-off-by: vividf <yihsiang.fang@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT
Don't merge this PR since we are moving to autoware-ml.
What
T4MetricV2'smin_num_pointsGT filter recomputed per-box point counts withpoints_in_rbboxon the model input point cloud (multi-sweep concatenation,after
remove_closeand range filtering). This PR changes it to use theannotation
num_lidar_ptsstored in the info pkl (keyframe count, thenuScenes/Waymo convention).
Why
Recomputing on the input cloud couples the evaluation GT set to the model input
pipeline:
boxes are evaluated, so runs with different input configs are not comparable
(an experiment that improves detection can show a lower mAP simply because its
input config resurrects harder GT boxes).
compensated, so the recomputed counts are physically wrong for moving
objects (smeared points fall outside the box).
remove_close, range filter) remove points fromboxes that the sensor actually observed, wrongly excluding them from GT.
The benchmark GT should be a fixed property of the dataset, not of the model
config. Note that the training-side filters (
ObjectMinPointsFilter)intentionally keep recomputing on the input cloud — that is a training
hyperparameter and is not changed here.
Verification
On the BEVFusion-L
j6gen2_baseval split (3,645 frames, kokseang_2_8_1 infos):num_lidar_ptsfield is fully populated (209,759 instances, 0 missing;17.5 % zero-point boxes from interpolated annotations are correctly dropped
by
min_num_points=2).(autoware-ml detection metric suite) class by class
(car 92,351 / bus 3,755 / bicycle 2,456 / pedestrian 35,186 /
traffic_cone 3,583 / barrier 524).
implementation to ±0.0004 (was −0.006 before this fix).
Side benefit: removes one
points_in_rbboxcall per frame from evaluation.