Remove build directory once build of jemalloc-sys finishes#119
Merged
Remove build directory once build of jemalloc-sys finishes#119
jemalloc-sys finishes#119Conversation
|
Welcome @Kobzol! It looks like this is your first PR to tikv/jemallocator 🎉 |
Author
|
The contributing guide link is 404. Do you have any suggestion on how to do the DCO sign-off? |
Kobzol
force-pushed
the
build-remove-build-dir
branch
from
fd235de to
9b4583d
Compare
Author
|
Added the signoff. |
Author
|
@BusyJay What do you think about this? :) |
Author
|
@BusyJay ping :) |
BusyJay
approved these changes
Dec 11, 2025
Member
|
You need to rebase master |
Kobzol
force-pushed
the
build-remove-build-dir
branch
from
9b4583d to
aea2b9a
Compare
And link to the libraries installed with `make install` instead. This saves disk space in the `target` directory. Signed-off-by: Jakub Beránek <berykubik@gmail.com>
Kobzol
force-pushed
the
build-remove-build-dir
branch
from
aea2b9a to
1a91147
Compare
Author
|
Done. I also ignored any potential errors, so that they don't impact the result of the build. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And link to the libraries installed with
make installinstead. This saves disk space in thetargetdirectory. When you build jemalloc multiple times, with different Cargo profiles, RUSTFLAGS etc., the files on disk will begin accumulating for no reason (if there is a change, Cargo will just rebuild the library in a different directory).Target directory disk space usage is a big concern to Rust users (https://blog.rust-lang.org/2025/02/13/2024-State-Of-Rust-Survey-results.html#challenges), and jemalloc is quite popular, so I think that it would be nice to improve this.
Fixes: #89