fix(atom): prevent listeners from being skipped during notify#404
Merged
tim-smart merged 2 commits intotim-smart:mainfrom Feb 11, 2026
Merged
fix(atom): prevent listeners from being skipped during notify#404tim-smart merged 2 commits intotim-smart:mainfrom
tim-smart merged 2 commits intotim-smart:mainfrom
Conversation
Owner
|
I took a look at this for effect v4 and ended up switch to a Set. Effect-TS/effect-smol#1173 Feel free to do the same, otherwise I'll backport it later. |
c18ab8a to
2c7c48d
Compare
Contributor
Author
|
@tim-smart Ok, did a backport |
tim-smart
approved these changes
Feb 6, 2026
Owner
|
Just needs a |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot the listeners array before iteration in Node.notify() to prevent skipping listeners when one unsubscribes itself during notification. The previous implementation iterated directly over this.listeners, which could cause subsequent listeners to be missed when earlier listeners mutated the array via unsubscribe.
Steps to reproduce the bug:
resultOnce, adds 1 listener nownotify()is called, first listener cleans up itself, mutateslistenersarray on nodenotify()never called