-
Notifications
You must be signed in to change notification settings - Fork 67
Release v2.3.0 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.3.0 #99
Conversation
Docker supports either CGroups v1 or v2 and while running under v2 the memory stat details change slightly. To account for FS cache we need to subtract out `memory_stats.stats.inactive_file` instead of `memory_stats.stats.total_cache` under v1. We found this despondency when running the latest `dockerd` on Debian Bullseye.
Moving to GitHub Actions for this
- Introduce requirements file - Add Makefile
9f24736 to
75bc72c
Compare
This makes for a more readable output when there are many containers Co-authored-by: Dennis Mücklich <58838393+dmueckli@users.noreply.github.com>
- Also removes erroneous debug print
I think this was probably a copy paste error. Fixing it will change the default behavior so that performance data is show. The original can be restored by simply using the --no-performance flag
4f58fd3 to
165d5ca
Compare
Co-authored-by: mlu <marek.luenenschloss@qplix.com>
|
Hi @timdaman I can't merge this due to the old CI settings that won't run anymore. Can you override this? Thanks |
timdaman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for bringing the forward nearly a decade.
|
|
||
| global no_performance | ||
| no_performance = args.no_ok | ||
| no_performance = args.no_performance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, that is a silly bug. Thanks for fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no worries. I've made my fair share of copy-paste mistakes
Done. |
|
Cool Thanks. I will have a look over the remaining PRs soon and then bump the version. |
Branch to prepare the new release.
Includes
Fixes #83 #81 #91 #93