Skip to content

Conversation

@martialblog
Copy link
Collaborator

@martialblog martialblog commented Jan 26, 2026

xyu and others added 4 commits January 26, 2026 09:07
Docker supports either CGroups v1 or v2 and while running under v2 the memory stat details change slightly. To account for FS cache we need to subtract out `memory_stats.stats.inactive_file` instead of `memory_stats.stats.total_cache` under v1.

We found this despondency when running the latest `dockerd` on Debian Bullseye.
Moving to GitHub Actions for this
- Introduce requirements file
- Add Makefile
This makes for a more readable output when there are
many containers

Co-authored-by: Dennis Mücklich <58838393+dmueckli@users.noreply.github.com>
- Also removes erroneous debug print
I think this was probably a copy paste error.
Fixing it will change the default behavior so that performance data is show.
The original can be restored by simply using the --no-performance flag
Co-authored-by: mlu <marek.luenenschloss@qplix.com>
@martialblog
Copy link
Collaborator Author

Hi @timdaman I can't merge this due to the old CI settings that won't run anymore. Can you override this?

Thanks

Copy link
Owner

@timdaman timdaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing the forward nearly a decade.


global no_performance
no_performance = args.no_ok
no_performance = args.no_performance
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, that is a silly bug. Thanks for fixing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no worries. I've made my fair share of copy-paste mistakes

@timdaman timdaman merged commit 537a96d into master Jan 27, 2026
2 checks passed
@timdaman
Copy link
Owner

Hi @timdaman I can't merge this due to the old CI settings that won't run anymore. Can you override this?

Thanks

Done.

@martialblog martialblog deleted the release/v2-3-0 branch January 27, 2026 07:08
@martialblog
Copy link
Collaborator Author

Cool Thanks. I will have a look over the remaining PRs soon and then bump the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forced combination of no_ok and no_performance

6 participants