fix: correct loop condition in GetFreeUserID and add tests - #143
Merged
joachimschmidt557 merged 2 commits intoAug 21, 2026
Merged
joachimschmidt557 merged 2 commits into
joachimschmidt557 merged 2 commits into
Conversation
The loop condition 'i > 0' was always false at start (i=0), causing the function to always hit log.Fatal. Changed to 'i >= 0'. Added tests for GetFreeUserID covering empty directory, gaps, and starting from zero.
Contributor
Author
|
again, closing this was unintended |
joachimschmidt557
requested changes
Aug 19, 2026
joachimschmidt557
approved these changes
Aug 21, 2026
joachimschmidt557
merged commit Aug 21, 2026
bfd34b4
into
timewarrior-synchronize:main
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop condition 'i > 0' was always false at start (i=0), causing the function to always hit log.Fatal. Changed to 'i >= 0'.
Added tests for GetFreeUserID covering empty directory, gaps, and starting from zero.