Conversation
|
Thanks for this - and sorry for the slow reply The feature itself looks well built. The typed AuthOutcome::PassphraseRequired instead of prompting from inside authenticate(), the non-blocking CoreEvent::KeyPassphraseRequired so the metrics poller never pops a dialog, the in-memory-only passphrase store, and the spawn_blocking around load_secret_key are all the right calls. Tests and CHANGELOG/README entries are there too. The problem is that the diff is unreviewable as pushed: 220 files, +37k/-36k. Almost all of it is mechanical noise from two git settings on your side: git diff --shortstat main...pr-103 -> 220 files, +37347 / -36507
Could you re-push with: git config core.fileMode false and a branch rebuilt on top of current main? That should land as roughly +912/-72 across ~35 files, which I can review properly |
357d03a to
fc94e3d
Compare
|
Rebuilt the branch on current main and re-pushed. The noise should be gone now. Diff is 35 files, +923/−83. Sorry about the review mess — should be readable now. |
Summary
Fixes #97
Test plan
hosts.tomlnever stores the passphrasessh-addthen connect with no prompt