fix: add days (d) unit to parse_duration#22
Open
sam-bamboo1979 wants to merge 1 commit into
Open
Conversation
The token regex already accepts 'd' in [wdhms], but _UNITS was missing the 'd' key, causing parse_duration to silently drop day values. - Add 'd': 86400 to _UNITS dict - Add test_days and test_days_combined tests - Update docstring to show day example Fixes tine1117#1
Author
|
Hi! Just wanted to follow up on this PR. It's been a few days since submission and I wanted to check if there's anything I can do to help move this along. Happy to make any adjustments if needed. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Problem
parse_durationsilently drops the days (d) unit. The token regex already acceptsdin[wdhms], but_UNITSwas missing thedkey, causing day values to be ignored.Fix
"d": 86400to_UNITSdicttest_daysandtest_days_combinedtestsVerification
All 9 tests pass (7 existing + 2 new):