Skip to content

fix: support day duration unit #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
380712766-dot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: support day duration unit #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion duration_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@

import re

# Seconds per unit. Supported: weeks, hours, minutes, seconds.
# Seconds per unit. Supported: weeks, days, hours, minutes, seconds.
_UNITS = {
"w": 604800,
"d": 86400,
"h": 3600,
"m": 60,
"s": 1,
Expand Down
4 changes: 4 additions & 0 deletions tests/test_duration_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@ def test_seconds(self):
def test_weeks(self):
self.assertEqual(parse_duration("1w"), 604800)

def test_days(self):
self.assertEqual(parse_duration("1d"), 86400)

def test_combined(self):
self.assertEqual(parse_duration("1h30m"), 5400)
self.assertEqual(parse_duration("2d4h"), 187200)

def test_invalid_raises(self):
with self.assertRaises(ValueError):
Expand Down