Configure TCP ACK ceiling per interface - #109
Merged
Merged
Conversation
This was referenced Sep 28, 2026
tinic
added a commit
that referenced
this pull request
Sep 28, 2026
#109 added ami_sana2_default_tcp_ack_max in sana2_policy.c with its own lower-case compare and basename walk, next to the identical static ami_str_iequal/ami_sana2_basename and WiFiPi name test in sana2_device.c. Both now live once in sana2_policy.c (pure, still host-linkable) and both WiFiPi defaults (128 posted reads, 11680 ACK ceiling) share one test. bsdsocket.library (preset default): 365,468 -> 365,316 bytes, text 338,636 -> 338,488; pre-#109 main was 364,956. The 366,000 budget stays. Host tests sana2_device and config_routes pass. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
tinic
pushed a commit
that referenced
this pull request
Sep 28, 2026
The beta6 -> beta7 delta also moves third_party/netxduo by one commit, 02a6f37e (per-interface TCP ACK ceilings), pinned by #109. zz9k-fpga reviewed it as part of #109 at 8d76cf1, which pins the same SHA; its tree is identical to the PR head 663e926e. Repro: tools/check-submodule-delta.sh v1.0.0-beta6 HEAD v1.0.0-beta7 -> submodule_delta=PASS moved=2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tinic
added a commit
that referenced
this pull request
Sep 28, 2026
The beta6 -> beta7 delta also moves third_party/netxduo by one commit, 02a6f37e (per-interface TCP ACK ceilings), pinned by #109. zz9k-fpga reviewed it as part of #109 at 8d76cf1, which pins the same SHA; its tree is identical to the PR head 663e926e. Repro: tools/check-submodule-delta.sh v1.0.0-beta6 HEAD v1.0.0-beta7 -> submodule_delta=PASS moved=2 Co-authored-by: claudecode <noreply@anthropic.com>
This was referenced Sep 28, 2026
tinic
added a commit
that referenced
this pull request
Sep 28, 2026
The v1.0.0-beta7 tag (7fd931d) contains #109 (TCPACKMAX, WiFiPi default 11,680) and #113 (TCPGROWRTT), but both entries sat under Unreleased. Notes cut from the beta7 section would have left them out and shown them as new in beta8. Moved into 1.0.0-beta7 unchanged, with the corrected sizes from #117. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TCPACKMAX to each NetInterfaces file (1..65535 bytes). If absent, WiFiPi interfaces use 11680 and other devices retain the existing 50176 default. Apply policy to the connected NetX interface before it is online, preserving independent wired and Wi-Fi behavior. Includes parser/default tests, user guide, and installer comment. NetX dependency: tinic/netxduo#4. No receive-window or delayed-ACK timer change. Verification: config_parsers and sana2_device host tests pass; m68k bsdsocket_library cross-build passes; diff checks pass. PR #108 global ACK setting should remain held/superseded by this scoped change.