Repository navigation
Conversation
winuae-run.sh wiped its staging drive (rm -rf "$HD", before staging and again before the copy back) with no drive claim. It now claims the drive right after HD is set, before the ROM push and the first wipe. Backend is none: the guest's network, bridged or not, lives on the Windows host, so there is no local bridge to claim and a host without flock(1) degrades with a warning rather than refusing. bridge-lock-selftest launcher_order: - emulator start lines come from an EMU_START table (amiberry, winuae); discovery is the union of the rows - drive claim < emulator start is asserted for every launcher, not only bridged ones - drive claim < first destructive line, where lines run through ssh act on the remote host and are skipped - a discovered launcher with no non-comment start fails (no-emulator-start); amiberry-run, run-workbench and winuae-run must be discovered (not-discovered otherwise) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An omitted or empty backend read as unbridged, so a caller that forgot it got the no-flock warning and an unlocked drive. It now returns 2; every caller already passes one. noflock_drive asserts the refusal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two #135 review follow-ups (deepseek-flash).
tools/winuae-run.shnow callsrig_claim_drive "$HD" ... noneright afterHDis set, before the ROM push and the firstrm -rf "$HD". It does not claim the bridge, because WinUAE's network (bridged or SLIRP) is on the Windows host and this host's locks do not cover it. So the backend isnone: on a host without flock(1) the claim warns and carries on instead of refusing.launcher_orderintools/bridge-lock-selftest.sh:EMU_STARTtable (amiberry, winuae). Discovery is the union of the rows.sshact on the remote host and are skipped.no-emulator-start).not-discovered).Tested on playhouse2. No emulator was booted.
tools/bridge-lock-selftest.shprintedlauncher_winuae-run=drive:177 bridge:none first_destructive:286 emulator:526,launcher_order=okandbridge_selftest=0.tools/check-harnesses.shprintedcheck_harnesses=PASS.shellcheck -S warningpassed on both files.launcher_order=wrong:tests/tools/fake-launcher.sh:no-emulator-start tools/classicwb.sh:drive(1175)>=emulator(425) tools/classicwb.sh:drive(1175)>=destructive(245) tools/winuae-run.sh:drive(525)>=emulator(524) tools/winuae-run.sh:drive(525)>=destructive(284), rc=1.launcher_order=wrong:tools/winuae-run.sh:not-discovered, rc=1.🤖 Generated with Claude Code