tests/netstack: host gates for the #38 multicast fan-out, both topologies - #69
Merged
Merged
Conversation
…gies The guest t_test_udp_reuseport drives a sender-is-primary fan-out that no host test covered; the missing-a1 test-helper clobber hid that gap. Add test_mcast_share_2sock (the sender is the port-list primary, the guest's shape) next to test_mcast_share_loopback (responder primary), both against the real netxduo fan-out, and raise HOST_TESTS_EXPECTED to 464. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two host tests pin the NetX Duo shared-socket multicast fan-out at the netxduo layer, in both topologies:
test_mcast_share_loopback— responder-primary (3 sockets): the multicast clone reaches the co-bound sibling.test_mcast_share_2sock— sender-is-primary (2 sockets): the shapet_test_udp_reuseportactually drives on the guest.Why
The guest's sender-is-primary fan-out had no host coverage; the missing-
a1test-helper clobber (fixed in #68) hid that gap and made the fan-out look broken when it was not. These lock the real send/loopback/fan-out path, both topologies, so a future regression there fails on the host.Changes
tests/netstack/host/test_mcast_share_2sock_host.c(new)tests/netstack/host/test_mcast_share_loopback_host.c(new)tests/netstack/CMakeLists.txt— shared netxduo source list, both executables + ctest entriestools/ci.sh—HOST_TESTS_EXPECTED462 → 464 (no non-x86 change; netstack host tests build on all arches liketest_bcast_loopback)Verification
Focused host run on landed main (
33abf15f):ctest -N= 464 (expected 464),mcast_share_loopback+mcast_share_2sockboth pass, host stage green (100% tests passed, 0 tests failed out of 464).🤖 Generated with Claude Code