Skip to content

tests, tools: every inline-asm LVO call lists all four scratch registers; CI gate (#70) #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tinic merged 1 commit into from
Sep 26, 2026
Merged

tests, tools: every inline-asm LVO call lists all four scratch registers; CI gate (#70) #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@ jobs:
tools/aminet-batch.sh \
tools/check-generated.sh \
tools/check-lvo-matrix.sh \
tools/check-lvo-clobbers.sh \
tools/check-option-stubs.sh \
tools/check-gitlinks.sh \
tools/check-test-duration.sh \
Expand Down
4 changes: 3 additions & 1 deletion tests/atf/atf_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,11 @@ static VOID atfc_set_errno_ptr(APTR ptr, LONG size)
register LONG d0 __asm("d0") = size;
register LONG _d1 __asm("d1");
register LONG _a1 __asm("a1");
register LONG _a0 __asm("a0");
register LONG _d0 __asm("d0");

__asm __volatile ("jsr a6@(-168:W)"
: "=r" (_d1), "=r" (_a1)
: "=r" (_d1), "=r" (_a1), "=r" (_a0), "=r" (_d0)
: "r" (a6), "r" (a0), "r" (d0)
: "cc", "memory");
}
Expand Down
2 changes: 1 addition & 1 deletion tests/compare/tickprobe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ static LONG s_close(LONG s)

__asm __volatile ("jsr a6@(-120:W)" : "=r"(r)
: "r"(a6), "r"(d0)
: "a0", "a1", "cc", "memory");
: "d1", "a0", "a1", "cc", "memory");
return r;
}

Expand Down
2 changes: 1 addition & 1 deletion tests/endurance/endurance.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ static LONG e_accept(struct Library *base, LONG s)
__asm __volatile ("jsr a6@(-48:W)"
: "=r" (res), "=r" (_clob_a0), "=r" (_clob_a1)
: "r" (a6), "r" (d0), "r" (a0), "r" (a1)
: "cc", "memory");
: "d1", "cc", "memory");
return res;
}

Expand Down
2 changes: 1 addition & 1 deletion tests/ipv6/ipv6_socket_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ BSD_SCRATCH;
__asm __volatile ("jsr a6@(-804:W)"
: BSD_SCRATCH_OUT
: "r" (a6), "r" (a0)
: "cc", "memory");
: "d0", "cc", "memory");
}

/* gai_strerror takes its argument in a0, not d0, pragmas line 141. */
Expand Down
2 changes: 1 addition & 1 deletion tests/leak/refused_leak_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ static LONG l_accept(struct Library *base, LONG s)
__asm __volatile ("jsr a6@(-48:W)"
: "=r" (res), "=r" (_clob_a0), "=r" (_clob_a1)
: "r" (a6), "r" (d0), "r" (a0), "r" (a1)
: "cc", "memory");
: "d1", "cc", "memory");
return res;
}

Expand Down
4 changes: 2 additions & 2 deletions tests/tcpdrill/tcpdrill.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ static LONG s_accept(LONG s)

__asm __volatile ("jsr a6@(-48:W)" : "=r"(r), "=r" (_clob_a0), "=r" (_clob_a1)
: "r"(a6), "r"(d0), "r"(a0), "r"(a1)
: "cc", "memory");
: "d1", "cc", "memory");
return r;
}

Expand Down Expand Up @@ -265,7 +265,7 @@ static LONG s_close(LONG s)

__asm __volatile ("jsr a6@(-120:W)" : "=r"(r)
: "r"(a6), "r"(d0)
: "a0", "a1", "cc", "memory");
: "d1", "a0", "a1", "cc", "memory");
return r;
}

Expand Down
4 changes: 3 additions & 1 deletion tests/tls/tls_loop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,11 @@ static LONG bsd_wait_select(struct Library *base, LONG nfds, APTR readfds,
register LONG res __asm("d0");
register LONG _clob_a0 __asm("a0");
register LONG _clob_a1 __asm("a1");
register LONG _clob_d1 __asm("d1");

__asm __volatile ("jsr a6@(-126:W)"
: "=r" (res), "=r" (_clob_a0), "=r" (_clob_a1)
: "=r" (res), "=r" (_clob_a0), "=r" (_clob_a1),
"=r" (_clob_d1)
: "r" (a6), "r" (d0), "r" (a0), "r" (a1), "r" (a2),
"r" (a3), "r" (d1)
: "cc", "memory");
Expand Down
8 changes: 4 additions & 4 deletions tests/tools/cardgrab.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ static struct CardHandle *cg_own_card(struct CardHandle *h)
register struct CardHandle *res __asm("d0");

__asm __volatile ("jsr a6@(-0x6)"
: "=r" (res)
: "r" (_a6), "r" (_a1)
: "=r" (res), "+r" (_a1)
: "r" (_a6)
: "d1", "a0", "cc", "memory");

return res;
Expand All @@ -78,8 +78,8 @@ static VOID cg_release_card(struct CardHandle *h, ULONG flags)
register ULONG _d0 __asm("d0") = flags;

__asm __volatile ("jsr a6@(-0xc)"
: "+r" (_d0)
: "r" (_a6), "r" (_a1)
: "+r" (_d0), "+r" (_a1)
: "r" (_a6)
: "d1", "a0", "cc", "memory");
}

Expand Down
6 changes: 4 additions & 2 deletions tests/tools/ifprobe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,9 +825,10 @@ static ULONG p_if_nametoindex(struct Library *base, const char *name)
register const char *a0 __asm("a0") = name;
register ULONG res __asm("d0");
register LONG _clob_d1 __asm("d1");
register LONG _clob_a0 __asm("a0");

__asm __volatile ("jsr a6@(-882:W)" /* if_nametoindex -0x372 */
: "=r" (res), "=r" (_clob_d1)
: "=r" (res), "=r" (_clob_d1), "=r" (_clob_a0)
: "r" (a6), "r" (a0)
: "d2", "d3", "a1", "cc", "memory");
return res;
Expand All @@ -840,9 +841,10 @@ static char *p_if_indextoname(struct Library *base, ULONG index, char *out)
register char *a0 __asm("a0") = out;
register char *res __asm("d0");
register LONG _clob_d1 __asm("d1");
register LONG _clob_a0 __asm("a0");

__asm __volatile ("jsr a6@(-888:W)" /* if_indextoname -0x378 */
: "=r" (res), "=r" (_clob_d1)
: "=r" (res), "=r" (_clob_d1), "=r" (_clob_a0)
: "r" (a6), "r" (d0), "r" (a0)
: "d2", "d3", "a1", "cc", "memory");
return res;
Expand Down
6 changes: 4 additions & 2 deletions tests/udpdrill/udpdrill.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,10 @@ register APTR a2 __asm("a2") = fromlen;
register LONG res __asm("d0");
register LONG _s_d1 __asm("d1");
register LONG _s_a0 __asm("a0");
register LONG _s_a1 __asm("a1");

__asm __volatile ("jsr a6@(-72:W)"
: "=r" (_s_d1), "=r" (_s_a0), "=r" (res)
: "=r" (_s_d1), "=r" (_s_a0), "=r" (_s_a1), "=r" (res)
: "r" (a6), "r" (d0), "r" (a0), "r" (d1), "r" (d2),
"r" (a1), "r" (a2)
: "cc", "memory");
Expand Down Expand Up @@ -273,9 +274,10 @@ register APTR a1 __asm("a1") = len;
register LONG res __asm("d0");
register LONG _s_d1 __asm("d1");
register LONG _s_a0 __asm("a0");
register LONG _s_a1 __asm("a1");

__asm __volatile ("jsr a6@(-96:W)"
: "=r" (_s_d1), "=r" (_s_a0), "=r" (res)
: "=r" (_s_d1), "=r" (_s_a0), "=r" (_s_a1), "=r" (res)
: "r" (a6), "r" (d0), "r" (d1), "r" (d2), "r" (a0),
"r" (a1)
: "cc", "memory");
Expand Down
3 changes: 2 additions & 1 deletion tools/check-gates-wired.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ want stage-coverage tools/ci.sh 'check-stage-coverage\.sh'
want rx-posted tools/ci.sh 'check-rx-posted\.sh'
want option-stubs tools/ci.sh 'check-option-stubs\.sh'
want lvo-matrix tools/ci.sh 'check-lvo-matrix\.sh'
want lvo-clobbers tools/ci.sh 'check-lvo-clobbers\.sh'
want generated .githooks/pre-commit 'check-generated\.sh'

# Gate 5: the push itself. .githooks/pre-push refuses a tree the host stage
Expand Down Expand Up @@ -198,7 +199,7 @@ done
# ------------------------------------------ and the gate scripts still run ---
for g in check-changelog-prose check-image-size check-ram-size check-rate \
check-stage-coverage check-rx-posted check-option-stubs \
check-lvo-matrix check-generated \
check-lvo-matrix check-lvo-clobbers check-generated \
check-hot-calls check-rearm-invariants check-hotpath-budget \
check-gates-wired; do
if [ ! -x "tools/$g.sh" ]; then
Expand Down
Loading
Loading