compress unscaled when original is active#114
Open
tijmenbruggeman wants to merge 10 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the plugin’s compression behavior to also optimize WordPress’s “unscaled original” file (stored in attachment metadata as original_image) when the scaled original is active, and updates sizing/credit estimation and tests accordingly.
Changes:
- Add an
original_unscaledsize concept and create aTiny_Image_Sizefor it whenoriginal_imageexists in attachment metadata. - Treat
original_unscaledas tied to the original size in settings (including preserve-metadata handling) and update free-compression estimates accordingly. - Update unit and Playwright integration tests to reflect the additional implicit compression count.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/class-tiny-image.php |
Introduces ORIGINAL_UNSCALED and creates an image-size entry from original_image metadata. |
src/class-tiny-settings.php |
Adds original_unscaled into the sizes map and allows preserve options for it; updates docblock typing/text. |
test/unit/TinySettingsAdminTest.php |
Updates expected sizes output and adds coverage for get_active_tinify_sizes() behavior. |
test/integration/settings.spec.ts |
Updates UI expectations for free compression estimates after the new implicit size is counted. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress scales down the original image when big_image_size_threshold is hit (defaults to 2560px). The scaled down version will be used when a user requests the
fullimage and generates thumbnails using the unscaled version.Users wanted to compress the unscaled original image as well as these might take up a lot of disk space.
Changes
src/class-tiny-image.phpwhen original image exists, will also add a Tiny_Image_Size for the unscaled version;get_active_tinify_sizeswill return the unscaled size when original is enabled;src/class-tiny-settings.phpwill preserve meta data on the unscaled version if enabled;Considerations