Remove dead live-preview path from tinyskills - #245
Open
Hotragn wants to merge 1 commit into
Open
Conversation
use-generation.ts handled a "source_streaming" event that no producer emits. The scrape route sends source_start, source_step, source_error, source_complete, scrape_complete, error and scrape_start -- never source_streaming -- so the branch never ran and ScrapeProgress.streamingUrl was never assigned. Both UI blocks gated on it were therefore unreachable. This is left over from before the recipe moved to TinyFish Fetch. The route now calls client.fetch.getContents(), a batch request with no browser session, so there is no streaming URL to surface. Wiring one up would mean switching back to the metered Agent endpoint, which is a product decision rather than a bug fix, so this removes the vestigial path instead: - ScrapeProgress.streamingUrl and the field copy in the route - the source_streaming branch in useGeneration - the two "Watch live" links that could never render - imports orphaned by those removals Verified with tsc --noEmit and eslint, both clean. Found by the check in tinyfish-io#244; refs tinyfish-io#86.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #86. Found by the conformance check in #244.
The bug
hooks/use-generation.tshad a branch for asource_streamingevent that nothing sends:grep -rn source_streaming tinyskills/returns exactly one line — the consumer. So the branch never ran,ScrapeProgress.streamingUrlwas never assigned, and both UI blocks gated on it were unreachable:app/page.tsx:366— external-link icon on a scraping rowcomponents/skillforge/source-progress.tsx:105— the "Watch live" tooltip linkWhy removing it is the right fix, not emitting it
This is left over from before the recipe moved to TinyFish Fetch. The route now calls
client.fetch.getContents({ urls, format: "markdown" })— a batch request/response with no browser session, so there is no streaming URL to surface.grep -rn "agent\.\|\.stream(" tinyskills/finds nothing; the recipe never touches the Agent endpoint.Making the "Watch live" link work again would mean moving this recipe back to the Agent endpoint, which is metered where Fetch is free. That's a product decision about the recipe's cost profile, not a bug fix, so it isn't mine to make in this PR. Removing the vestigial path leaves the recipe honest about what it actually does.
Changes
types/index.ts— dropScrapeProgress.streamingUrlapp/api/scrape-sources/route.ts— drop the field copy intofinalResultshooks/use-generation.ts— drop thesource_streamingbranchapp/page.tsx,components/skillforge/source-progress.tsx— drop the two unreachable linksExternalLink, andTooltip*insource-progress.tsx)Net −47/+1. No behaviour change: every removed path was already unreachable.
components/ui/tooltip.tsxis left in place as an unused shadcn primitive.Verification
Note
npm run lintfails on its own — the script isnext lint, which Next removed after 14. Unrelated to this change, but worth knowing if you try it.