Doctor skill: reach from proves_harness_reach, and the README's telemetry claim - #30
Conversation
…elemetry note Self-review against CLI 0.32.0 found four wrong claims in the skills shipped by #29 and a false privacy statement in the README: `proves_harness_reach` is true whenever the harness's own client reports a live connection — Claude Code on OAuth included — and doctor reports every run, not only the ones that repair. - doctor skill: reach and `registration: pass` described by `proves_harness_reach` rather than by auth mode - doctor skill: `repairs[].command` arrives as bare `tinyfish …`, which is not on PATH under npx — say to swap the leading word - doctor skill: the Cursor `unattended_safe` caveat holds on `3`, not only `2` - feedback skill: title goes to a file like the body; a `title=…` assignment evaluates backticks just as the command line does - README: doctor reports every run, and diagnosis makes authenticated calls - 1.3.0 → 1.3.1, plugin.json and the marketplace entry together Skills are byte-identical to tinyfish-cookbook#262, the other copy of this plugin. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 29 minutes. View limit detailsLimit details: You’ve used all 3 included reviews currently available. Your 49 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Comment |
Zechereh
left a comment
Zechereh
left a comment
There was a problem hiding this comment.
Verified the skill's CLI claims against the published @tiny-fish/cli 0.32.0 tarball — repair commands, unattended_safe gating, proves_harness_reach, doctor telemetry all match. Skills are hash-identical to cookbook#262's head.
One question: #262 is still open — if its review changes the wording, does a re-sync follow up here?
| `connect` repair beside it. On `1`, and on every OAuth or `auth_mode: unknown` registration | ||
| at any version, pass is presence only: doctor read config, not the wire, and a stale key | ||
| still passes while every call 401s. Neither version says anything about siblings, and a | ||
| `connect` repair beside it. A pass carrying `proves_harness_reach: true` is the harness's own |
There was a problem hiding this comment.
Line 57 says true can also come from a wire-verified key; this line credits only the client-reported connection. Suggest: "…is wire evidence — the harness's client reported a live connection or doctor verified the key."
|
|
||
| - Preferred: write the body to a file and the summary to a variable, then | ||
| `gh issue create --repo tinyfish-io/tinyfish-cookbook --title "$title" | ||
| - Preferred: write the body and the title to files, then `gh issue create |
There was a problem hiding this comment.
Nit: worth a clause that the write itself can't go through the shell either — an unquoted heredoc evaluates $(…) at the write step.
3 participants
registration: passdescribed byproves_harness_reach, not byauth_mode— the old text had the agent report real wire evidence as unverified presencerepairs[].commandarrives as baretinyfish …, which is not on PATH on the npx-only installs this skill targetsunattended_safecaveat holds on3too — the gate is unchanged"$title"left the injection at thetitle=…assignmentplugin.jsonand the marketplace entrySkills are byte-identical to tinyfish-io/tinyfish-cookbook#262