Initialize room store only once#3
Open
Adarsh-9182 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useCreateStoreinitializer.setJson(initialJson)during render, which can reset the room store on re-renders.Why
Calling
setJson(initialJson)during render can overwrite synchronized room state wheneverRoomStorere-renders. In collaborative rooms, that can make shapes appear to jump back to stale positions while remote updates are also being applied.This should help with the flickering/jank described in #2.
Verification
npm run tscurrently fails on upstream-existing errors insrc/client/common.tsandsrc/server/common.ts; this change did not add errors inRoomStore.tsx.npm run lintcurrently fails becauseeslint-plugin-jsdocis referenced by the ESLint config but is not installed as a dependency.Refs #2