adipy: port to py3k#1
Open
cyphar wants to merge 2 commits intotisimst:masterfrom
cyphar:py3k
Open
Conversation
BrendanDrew
reviewed
May 22, 2018
BrendanDrew
left a comment
BrendanDrew
left a comment
There was a problem hiding this comment.
I was just about to send a similar set of changes (albeit not nearly as well done as this). I would vastly prefer to have these changes rather than attempt to work with a custom fork of adipy. Is there something I can do to help with the review / integration of this patch and downstream release of an updated ADiPy to PyPI?
This fixes up all of the issues that adipy had with running on Python 3, without sacrificing the ability to run it on Python2. This also includes some module cleanups. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes up all of the issues that adipy had with running on Python 3,
without sacrificing the ability to run it on Python2. This also includes
some module cleanups.
Signed-off-by: Aleksa Sarai cyphar@cyphar.com