add make install target for homebrew formula

[kouk]

Homebrew maintainers asked for a make install target. Would be great if you could merge this.

[tiwe-de]

This only installs some of the files and doesn't respect the DESTDIR variable.

[kouk]

@tiwe-de I added DESTDIR support.

[MikeMcQuaid]

This only installs some of the files

Which files are missing?

This is why I suggested we add a make install for Homebrew otherwise it's a bit unclear what files should be installed.

[tiwe-de]

I commented on this already in the homebrew pull request.

An install target would depend on all and install basically anything the Debian package has. @kouk's install target misses afssh.1, ssh-askpass-noinput + manpage and the bash-completion functions.

I'll work on that these days.

[tiwe-de]

@MikeMcQuaid how are the paths you use for bash-completion files, READMEs and changelogs?

[MikeMcQuaid]

@tiwe-de We use standard paths for all so feel free to make make install put everything in the Debian-usual locations.

[MikeMcQuaid]

Not sure about Debian but are these not usually in share/man? If not, could you make this MANDIR ?= so Homebrew could customise it? Thanks!

[tiwe-de]

Unfortunately adding an install: all target makes the Debian package build it twice, the second time under fakeroot. I'll have to find a solution which makes the version.h target less phony, first.

[kouk]

@tiwe-de if you think I can contribute some way let me know. I'm a bit confused as to what the status is.

[kouk]

@tiwe-de any ideas about this? Do you think you will find time to implement it? If not I can attempt to do it according to the comments above.

[tiwe-de]

I need a solution where:

• version.h is regenerated when the checked-out version in git changes
• version.h is not touched when the source is not in git (extracted from a tarball)
• nothing is rebuilt when make is run twice in a row