Repository navigation
Harden privacy boundaries for trace identifiers - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userIdandsessionIdinto privacy metadata, remove raw identity fields from sanitized raw span payloads, and stop promoting raw identities into normalized span attributes.doctor, and warn on every config-loading CLI command whenprivacy.store_raw_iois enabled..agentprof/.gitignoreduringagentprof initand refresh README examples to export a sufficiently long salt beforedoctorand imports.Review
userId/sessionIdafter hashing and adding import-level coverage.doctorwould break older workspaces missing.agentprof/.gitignore; fixed by keeping.gitignorecreation ininitwithout making it a doctor requirement.sessionId; fixed so normalized session IDs come only fromsession_hash.Tests
uv run pytest tests/test_cli.py tests/test_privacy_hashing.py tests/test_langfuse_export_import.py tests/test_normalize.pyuv run pytestuv buildgit diff --check