Repository navigation
Add static HTML report renderer - #22
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 925b908fa4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return lines | ||
|
|
||
|
|
||
| def _html_report(payload: dict[str, Any]) -> str: |
There was a problem hiding this comment.
Wire HTML renderer into report generation
This commit adds _html_report, but the production code path still never invokes it, so users cannot actually get an HTML artifact from agentprof report generate or report show (only Markdown/JSON remain available). I verified call sites with repo search and found _html_report is only used in tests, which means this renderer is currently dead code and the advertised feature is not delivered in runtime workflows.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in 42a4ab3. The HTML renderer is now invoked by generate_report, writes <report-id>.html, persists report_html_path, prints the HTML path from report generate, and supports agentprof report show --format html through the existing safe artifact path handling. I also updated report/CLI tests and README/docs. Verification: git diff --check, uv run pytest tests/test_report.py, and uv run pytest.
Summary
Verification
git diff --checkuv run pytest tests/test_report.pyuv run pytest