Skip to content

Add static HTML report renderer - #22

Merged
tjdonley merged 2 commits into
mainfrom
feat/html-report-renderer
Apr 29, 2026
Merged

tjdonley merged 2 commits into
mainfrom
feat/html-report-renderer

Conversation

@tjdonley

Copy link
Copy Markdown
Owner

Summary

  • Add a self-contained HTML report renderer for the existing report JSON payload.
  • Render summary cards, optional visual references, issue cards with evidence, and cost ledger rows.
  • Cover empty states, visual references, cost ledger rendering, and HTML escaping in report tests.

Verification

  • git diff --check
  • uv run pytest tests/test_report.py
  • uv run pytest

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 925b908fa4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

return lines


def _html_report(payload: dict[str, Any]) -> str:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wire HTML renderer into report generation

This commit adds _html_report, but the production code path still never invokes it, so users cannot actually get an HTML artifact from agentprof report generate or report show (only Markdown/JSON remain available). I verified call sites with repo search and found _html_report is only used in tests, which means this renderer is currently dead code and the advertised feature is not delivered in runtime workflows.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 42a4ab3. The HTML renderer is now invoked by generate_report, writes <report-id>.html, persists report_html_path, prints the HTML path from report generate, and supports agentprof report show --format html through the existing safe artifact path handling. I also updated report/CLI tests and README/docs. Verification: git diff --check, uv run pytest tests/test_report.py, and uv run pytest.

@tjdonley
tjdonley merged commit 6d5c17f into main Apr 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant