Skip to content

Fix secret redaction and overlapping waste totals - #26

Merged
tjdonley merged 2 commits into
mainfrom
agent/fix-redaction-and-report-totals
Aug 12, 2026
Merged

tjdonley merged 2 commits into
mainfrom
agent/fix-redaction-and-report-totals

Conversation

@tjdonley

Copy link
Copy Markdown
Owner

Summary

  • canonicalize mapping keys across camelCase, acronym-prefixed, and separated forms, then redact a broader set of credential-bearing keys
  • redact common AWS, GitHub, Google, Slack, npm, and PyPI credential formats in free text
  • deduplicate issue attribution by underlying trace/span allocation while reporting gross and overlapping waste separately
  • update the bundled demo reports and documentation for the corrected $0.054 recoverable total

Testing

  • pytest -q (141 passed)
  • changed-file Ruff E/F checks
  • python -m compileall -q agentprof
  • pip check
  • verified checked-in demo Markdown and HTML exactly match rendering from demo.json

@tjdonley
tjdonley marked this pull request as ready for review August 12, 2026 16:05

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 285684c7c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread agentprof/privacy/redactor.py Resolved

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 3f2dea596f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@tjdonley
tjdonley merged commit 8c8858f into main Aug 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant