Repository navigation
Add research comparing marcoroth/herb#2260 with tk0miya/rubocop-herb - #6
Merged
Merged
Conversation
Evaluate the RuboCop plugin proposed in marcoroth/herb#2260 against tk0miya/rubocop-herb 2cf8414, and add the reproduction setup. The setup uses the prebuilt herb 0.11.0 gem and loads the PR's gem from the Bundler git source, so the herb C extension is never built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gems/rubocop-herbatd0323df) and compare it with tk0miya/rubocop-herb2cf8414(latest main), both in implementation and in actual runs (research/herb-pr2260.md)research/repro/herb-pr2260/, new "herb PR #2260" section inresearch/repro/README.md)Key findings
ruby_extractorsAPI, but the PR blanks out<%=and HTML viaHerb.extract_rubyand has no autocorrect guardrubocop -achanged the HTML of 63 files (59 with new Herb parse errors) with the PR, vs 0 with tk0miya/rubocop-herb. The main causes areLayout/ExtraSpacing(enabled by default) andLint/VoidLayout/ExtraSpacing,Lint/Voidon output tags, andLint/EmptyBlockon HTML-only blocksLint/EmptyFile,Naming/FileName,Layout/EmptyLineAfterMagicCommentReproduction environment
rubyplatform is removed fromGemfile.lock, and the steps useBUNDLE_FROZEN=true bundle install, so the herb C extension is never builtglob: gems/rubocop-herb/*.gemspec), pinned to the PR headNotes
report.md,switching-decision.mdand the existing "rubocop-herb" section ofresearch/repro/README.mdstill target6601d3e; this memo targets2cf8414. Updating them is left for a separate change🤖 Generated with Claude Code