Repository navigation
Update the herb PR #2260 comparison to rubocop-herb 24ec034 - #7
Merged
Merged
Conversation
Rerun the comparison with tk0miya/rubocop-herb 24ec034 and revise the evaluation of the offenses only rubocop-herb reports: Layout/LineLength and Lint/EmptyFile are valid, Layout/EmptyLineAfterMagicComment changes the template output with -a, and Naming/FileName misreports locale variants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
research/herb-pr2260.mdagainst tk0miya/rubocop-herb24ec034(latest main). The PR side (Ruby: Add RuboCop support for Ruby in ERB templates marcoroth/herb#2260 atd0323df) is unchangedLayout/LineLengthis measured only on lines with ERB tags, andLayout/ElseAlignment/Layout/BlockEndNewlineno longer fire across ERB tags.-astill changes the HTML of 0 filesresearch/repro/README.mdRevised evaluation of the offenses only rubocop-herb reports
Layout/LineLength(162): valid. 109 lines are long because of the Ruby inside ERB tags (fixable by RuboCop), and 53 because of the surrounding HTML (fixable byherb-format).herb-formatdefaults tomaxLineLength: 80while RuboCop defaults to 120. The autocorrect places%>at the start of a lineLint/EmptyFile(16): valid. It fires only on 0-byte templates; the one in conference-app is aneditview whose route and controller action existLayout/EmptyLineAfterMagicComment(3): the magic comment detection is correct, but-ainserts a blank line and changes the template outputNaming/FileName(3): only the locale varianthello_world.pt-BR.html.erbis a false positive🤖 Generated with Claude Code