fix: bump deepagents pin to >=0.5.1 (fixes CI break from #135) - #136
Open
chrispatil wants to merge 1 commit into
Open
fix: bump deepagents pin to >=0.5.1 (fixes CI break from #135)#136chrispatil wants to merge 1 commit into
chrispatil wants to merge 1 commit into
Conversation
PR tkellogg#135 added artifacts_root=str(self.layout.state_dir) to the CompositeBackend(...) call in app.py, but the deepagents pin (>=0.4.1) resolves to a version that doesn't have that parameter, causing CI to fail immediately after merge: TypeError: CompositeBackend.__init__() got an unexpected keyword argument 'artifacts_root' artifacts_root was added upstream in deepagents 0.5.1. Bumping the minimum pin resolves the failure. Verified locally against the same test selection CI uses: 337 passed, 1 skipped, clean. Follow-up worth filing separately: this repo's CI workflow only triggers on push to main, not on PR branches, so PR tkellogg#135 never got machine-tested before merge. Adding on: pull_request would catch this class of issue pre-merge next time. Drafted by Tyto (Chris Patil's agent), follow-up to our own PR tkellogg#135.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
#135 added
artifacts_root=str(self.layout.state_dir)to theCompositeBackend(...)call inapp.py. That kwarg doesn't exist indeepagents0.4.1 — the version our pin (deepagents>=0.4.1) resolves to. It was added upstream indeepagents0.5.1. This broke CI immediately after #135 merged:Confirmed by installing both
deepagentsversions in isolated venvs and inspecting the constructor signature, and by reproducing the exact CI failure on a clean checkout of the merge commit (https://github.com/tkellogg/open-strix/actions/runs/30965334871).Why it slipped through
The PR branch for #135 had zero CI check-runs before merge — this repo's workflow appears to trigger on push to
mainonly, not on PR branches. So review and CI never both ran against that diff until after merge. Might be worth a separate follow-up addingon: pull_requestso this class of issue gets caught pre-merge next time — not included in this PR to keep it scoped to the actual fix.Fix
Bump
deepagents>=0.4.1→deepagents>=0.5.1inpyproject.toml, regenerateuv.lock. Left the bound unbounded rather than a tighter>=0.5.1,<0.6.0range — tested both, and the tighter range still resolves to 0.5.9 with the same langchain/langgraph cascade, so no isolation benefit, just an extra pin to maintain.Verification
Ran the same test selection CI uses (matched against the failed run's job config): 337 passed, 1 skipped, clean.
Drafted by Tyto (they/them), Chris Patil's agent, as a follow-up to our own #135. Chris reviewed and approved filing.