Use fromDerSignature function from @turnkey/crypto #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not checked to be 0x30, No checks for canonical (minimal) representation of DER-encoded numbers, Bounds for array slicings are not checked
leeland-turnkey
commented
Dec 10, 2025
…tion between repos
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
leeland-turnkey
changed the title
andrewkmin
reviewed
Dec 12, 2025
export-and-sign/package.json
Outdated
| "@noble/ed25519": "2.0.0", | ||
| "@noble/hashes": "1.3.2", | ||
| "@solana/web3.js": "1.98.4", | ||
| "@turnkey/crypto": "^2.8.6", |
Contributor
There was a problem hiding this comment.
tiny nit: let's hard-pin this dependency just to keep things consistent/locked down
Contributor
Author
There was a problem hiding this comment.
Done. Is this a normal approach here at Turnkey?
Contributor
There was a problem hiding this comment.
It sorta depends. In security-critical packages or here in frames, we would prefer to, just to be really on top of the dependencies we're using. Otherwise, in less-security-critical places like example apps, it's not as critical
andrewkmin
approved these changes
Dec 12, 2025
leeland-turnkey
deleted the
leeland/eng-2788-tob-55-the-fromdersignature-function-in-export-and-sign
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using export function
fromDerSignaturefrom@turnkey/cryptoto standardize this function between repos. They are both supposed to have the same functionality anyways. Since this function specifically looks for short form, we don't need to support long form length:https://github.com/tkhq/sdk/blob/3406928772254aeb4f47259e43d8618a677dd0a2/packages/crypto/src/crypto.ts#L671-L672