Remove nacl and tweetnacl-util package #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkmin
reviewed
Dec 17, 2025
| const signature = nacl.sign.detached(messageBytes, keypair.secretKey); | ||
|
|
||
| // Set up sha512 for nobleEd25519 (required for signing) | ||
| nobleEd25519.etc.sha512Sync = (...m) => |
Contributor
There was a problem hiding this comment.
tiny nit: can we rename this variable (...m) for clarity?
Contributor
Author
There was a problem hiding this comment.
It looks like this is the convention used in a few other spots in this repo:
https://github.com/tkhq/frames/pull/87/files#diff-94d56eb146262b2caf0bf87fac93c934afded3304706f9b0db0e646e61140bd3R607
Contributor
There was a problem hiding this comment.
fair, not pinning this on you
andrewkmin
approved these changes
Dec 17, 2025
leeland-turnkey
deleted the
leeland/eng-2791-tob-58-dependencies-of-the-export-and-sign-are-not-minimal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove nacl and tweetnacl-util package and replace those functions with
@noble/ed25519and@noble/hashes/sha512. I wasn't sure what the best way to confirm they are the same. I console.log both the previous signature and the new one and they came out the same.All tests are passing