Conversation
This is a huge amount of new code. Has it been reviewed? I believe the policy for qos is to review every dependency line by line. |
|
It could take a day or more to review the diffs between all these libraries for supply chain attacks, so should probably flag this for approval to spend that much time. Are we actually patching any vulns that impact any actual codepaths we use? |
|
What I'd like to propose is the following:
|
|
Quick update on this: as I understand it,
Also note that some already-merged previous PRs have partially improved the situation by bumping versions for known problems in some sub-crates, for example the problematic |
Summary & Motivation (Problem vs. Solution)
This PR addresses security vulnerabilities by updating key dependencies to their latest, patched versions, ensuring SOC2 compliance.
Vulnerable Package Updates
1.1.01.3.0root@0.8.8,qos_enclave@0.8.60.8.110.11.10.12.10.10.520.10.640.1.450.3.360.37.150.38.34Required Package Updates
1.28.01.38.0mio0.2.1480.2.1551.2.21.3.1shlex,vmm-sys-util,openssl,rustixIrremediable
rsa- MEDIUMWork is ongoing to resolve this vulnerability.
rsais a dependency ofyubikey, and it is anticipated thatyubikeywill update theirrsadependency to the latest patched version once available.atty- LOWAs of now, there is no known remediation for
atty, and the package appears to be unmaintained, according to GitHub vulnerability information.attyis a dependency ofclap, which is a Rust command line parser used bynitro-cli. Newer versions ofclaphave removedattyas a dependency.How I Tested These Changes
make test&make buildin affected modulesPre merge check list