Repository navigation
chore(release): CLI 와 상관없는 경로를 CLI 릴리스에서 제외하기 - #248
Merged
Merged
Conversation
- release-please 는 바뀐 파일 경로로 패키지를 고르므로, README 그림(assets/readme)과 AGENTS.md 만 바뀐 companion 작업도 CLI 릴리스를 만들었음 (2.36.0, 2.38.0, 2.39.0 릴리스 PR) - 루트 exclude-paths 에 assets/readme, AGENTS.md 와 monorepo 도구 파일(package.json, pnpm-lock.yaml, pnpm-workspace.yaml)을 추가 - CLI 가 쓰는 .claude-plugin, .agents, integrations, install.sh 와 CLI 와 함께 배포되는 apps/agent-runtime 은 그대로 CLI 에 남김
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
release-please 는 커밋 scope 가 아니라 바뀐 파일 경로로 패키지를 고릅니다. 루트(CLI) 패키지는
exclude-paths에 없는 파일이 하나라도 바뀌면 CLI 변경으로 셉니다. README 그림과AGENTS.md가 빠져 있어서 companion 작업이 CLI 릴리스를 만들었습니다.assets/readme/dashboard-*.svgassets/readme/*.svg(문서 커밋 2개).apps/agent-runtime은 CLI 와 함께 배포되므로 정상AGENTS.md변경
release-please-config.json루트exclude-paths에 다음을 추가합니다.assets/readme: README 그림AGENTS.md: agent 지침package.json,pnpm-lock.yaml,pnpm-workspace.yaml: monorepo 도구 파일. companion 의존성만 바뀌어도pnpm-lock.yaml이 바뀌고, CLI(Bash)는 쓰지 않음.claude-plugin,.agents,integrations(CLI 의hooks install이 직접 씀),install.sh,apps/agent-runtime(CLI 태그로 함께 배포),rust-toolchain.toml은 CLI 에 그대로 둡니다.확인
python3 -m json.tool release-please-config.json: 통과v2.38.0..HEAD의 모든 커밋(merge 포함)을 새exclude-paths로 걸렀을 때 CLI 로 잡히는 커밋: 없음. 머지 후 chore(main): release 2.39.0 #246 같은 CLI 릴리스 PR 이 다시 생기지 않고, companion 은 chore(main): release workbranch-companion 2.34.0 #247 (2.34.0) 로 릴리스됩니다.