get_nearest_locations returns the wrong point#272
Open
pleasantone wants to merge 6 commits into
Open
Conversation
also trivial typing fixes elsewhere
Author
|
@tkrajina your thoughts? |
tkrajina
force-pushed
the
dev
branch
2 times, most recently
from
August 5, 2024 10:21
352c97d to
b866ab4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_nearest_locations was returning the correct track/segment/point numbers et al, but the wrong point(s)
needed to save/return point_candidate, not a less appropriate point
...also trivial typing fixes elsewhere