Skip to content

fix: preserve negative timezone offsets when cloning gpx #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: preserve negative timezone offsets when cloning gpx #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gpxpy/gpxfield.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ def dst(self, dt: Optional[mod_datetime.datetime]) -> mod_datetime.timedelta:
def tzname(self, dt: Optional[mod_datetime.datetime]) -> str:
if self.offset == 0:
return 'Z'
return f'{self.offset // 60:02}:{self.offset % 60:02}'
sign = '-' if self.offset < 0 else '+'
offset = abs(self.offset)
return f'{sign}{offset // 60:02}:{offset % 60:02}'

def __copy__(self) -> mod_datetime.tzinfo:
return self.__deepcopy__()
Expand Down
12 changes: 12 additions & 0 deletions test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3127,6 +3127,18 @@ def test_timezone_from_timestamp(self) -> None:
self.assertTrue(t_stamp + "+01:00" in reparsed.to_xml() or t_stamp + "+0100" in reparsed.to_xml())
self.assertTrue(reparsed.tracks[0].segments[0].points[0].time.tzinfo) # type: ignore

def test_deepcopy_negative_simpletz(self) -> None:
xml = '<?xml version="1.0" encoding="UTF-8"?>\n'
xml += '<gpx>\n<trk>\n<trkseg>\n'
xml += '<trkpt lat="1" lon="2"><time>2018-04-04T10:36:53-06:00</time></trkpt>\n'
xml += '</trkseg></trk></gpx>\n'
gpx = mod_gpxpy.parse(xml)
clone = gpx.clone()
original_time = gpx.tracks[0].segments[0].points[0].time
cloned_time = clone.tracks[0].segments[0].points[0].time
self.assertEqual(original_time, cloned_time)
self.assertEqual(cloned_time.utcoffset(), mod_datetime.timedelta(hours=-6)) # type: ignore

def test_timestamp_with_single_digits(self) -> None:
xml = '<?xml version="1.0" encoding="UTF-8"?>\n'
xml += '<gpx>\n'
Expand Down