build: embed version string in all platform artifacts - #6
Merged
Conversation
- Add APP_VERSION cmake variable (parsed from x.y.z into MAJOR/MINOR/PATCH) - macOS: set CFBundleShortVersionString/CFBundleVersion via cmake bundle properties and bundle_macos.sh Info.plist generation - Linux/DEB: CPACK_PACKAGE_VERSION now uses APP_VERSION instead of hardcoded 1.0.0 - Windows: generate P2ProViewer.rc from template (src/P2ProViewer.rc.in) with VERSIONINFO and icon resource; icon converted from icon.png in CI - CI: add determine-version job that runs semantic-release --dry-run on main (fallback: last git tag) and passes the result to all build jobs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
determine-versionCI job that runssemantic-release --dry-runonmain(fallback: last git tag) and passes the resolved version to all build jobsCFBundleShortVersionString/CFBundleVersionvia cmake bundle properties andbundle_macos.shInfo.plist generationCPACK_PACKAGE_VERSIONnow usesAPP_VERSIONinstead of the hardcoded1.0.0src/P2ProViewer.rc.intemplate generates a resource file withVERSIONINFO(visible in Explorer → Properties → Details) and an embedded icon (converted fromicon.pngvia ImageMagick in CI)Test plan
determine-versionlogs show last git tag versionfix:/feat:commit tomain→ verifydetermine-versionoutputs the next semver and all three build jobs use itGet Infoon.appshows correct version; checkInfo.plistcontainsCFBundleShortVersionStringdpkg --info *.deband verify the package version matches the release version🤖 Generated with Claude Code