Compare TLAPM AST with expected AST in syntax tests #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
This was referenced Sep 4, 2025
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes extend the work in #159 - which only ran the tests in a simple pass/fail manner - to also compare TLAPM's AST to the expected AST encoded as an S-expression. This entails a bunch of code to translate TLAPM's AST to the expected S-expression format for comparison.
As TLAPM is naturally the most detailed parser with regard to the proof language (and, due to exhaustive pattern-matching over invariants in OCaml, easy to see what code is & is not exercised) a number of gaps in the proof language test corpus were also filled.