Fixed taint propagation for String conversion fast path and utf8 strings#11
Fixed taint propagation for String conversion fast path and utf8 strings#11alexbara2000 wants to merge 2 commits into
Conversation
|
Hi @alexbara2000, thanks for the PR! I have a couple of comments - I think this would make sense to merge directly to https://github.com/SAP/project-foxhound, rather than the primitaint branch. We can then pull stuff to primitaint to ensure the fix is there too. Can you also add a regression test for the issue as well? You had a nice code snippet in the issues. Let me know if you need support on where to do this. |
|
Hey, For sure I can add a couple tests for this PR. Just to make sure, are regression tests the ones in |
|
That's where the tests live that can be tested in a pure JavaScript environment. I think in this case you need access to DOM objects as well though right? If so we have some tests here: https://github.com/SAP/project-foxhound/tree/main/taint/test/mochitest which you can add to. |
The taint was being lost for string conversion due to fast path being taken when classes were being used. The taint was also being lost for utf8 conversion (special case). Both issues have been fixed and tested.