fix: blink edit no longer adds local paths - #10
Merged
Conversation
Signed-off-by: Ignas Bernotas <ignas@toawe.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blink editloaded the config through the resolving loader, which fillsdir_rootand the fourpathsentries with absolutes derived from the machine it ran on. The picker handed that same struct back to the writer, so saving turned a portable, committable config into one pinned to one developer's home directory.Adds
loader.LoadRaw, which decodes and validates a config exactly as written on disk with nothing derived, and points the edit command at it. Values the file does set round-trip verbatim; omitted ones stay omitted.loader.Loadkeeps its resolving behavior for the runtime and is now built on the raw path.