fix: changelog ignored branch's commits before merge - #4
Merged
Conversation
Signed-off-by: Ignas Bernotas <ignas@toawe.me>
Signed-off-by: Ignas Bernotas <ignas@toawe.me>
Signed-off-by: Ignas Bernotas <ignas@toawe.me>
Signed-off-by: Ignas Bernotas <ignas@toawe.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you ran
care changelogon a feature branch before merging, it only listed the commits that were already on main. A branch with 15 commits past the last tag would show the 1 that had landed.The reason is that care asked the git host for the commit list instead of reading your local checkout. The host can't see an unmerged branch, and when you pass
HEADit assumes you mean its default branch, so you got main's history back no matter where you were standing. That same mistake stripped author handles and pointed the compare link and contributor list at main.Now care gets the commit list from local git and only asks the host to fill in author handles. When it does talk to the host, it sends the real branch name instead of
HEAD.Nothing changes about how you call it. One thing to know: on a branch you haven't pushed, the compare link will 404 instead of quietly pointing at main.