validate_with_schema skips the query inside INSERT ... SELECT

[kvlonge]

Summary

validate_with_schema() does not validate the query inside INSERT ... SELECT. An unknown column is reported in a plain SELECT but not when the same SELECT feeds an INSERT.

Reproduction

pip install polyglot-sql==0.12.1

import polyglot_sql

schema = {"tables": [
    {"name": "orders", "columns": [{"name": "order_id", "type": "INT"}]},
    {"name": "order_archive", "columns": [{"name": "order_id", "type": "INT"}]},
]}
for sql in (
    "SELECT missing FROM orders",
    "INSERT INTO order_archive (order_id) SELECT missing FROM orders",
):
    result = polyglot_sql.validate_with_schema(sql, schema, dialect="postgres")
    print(result.valid, [(error.code, error.message) for error in result.errors])

Actual

False [('E201', "Unknown column 'missing' in table 'orders'")]
True []

Expected

Both statements are invalid with the same E201 error. The source query of INSERT ... SELECT should be validated like a standalone SELECT.

[tobilg]

Thanks for reporting, this will be fixed in the 0.13.0 release that will be done today. Please check and close if this fixed your issue.