Fix Simandoux Sw exponent and mud-filtrate salinity input#12
Open
dougchristie wants to merge 1 commit into
Open
Fix Simandoux Sw exponent and mud-filtrate salinity input#12dougchristie wants to merge 1 commit into
dougchristie wants to merge 1 commit into
Conversation
- Simandoux water saturation used (d**2 + e) ** 0.2; the closed-form quadratic solution requires a square root (** 0.5). With the fix, Simandoux correctly reduces to Archie when Vclay = 0. - Correct the matching Simandoux docstring to use a square root instead of a square so the documented equation matches the code. - rmf68 (mud-filtrate resistivity at 68 F) was scaled by rws (water) instead of rmfs (filtrate), corrupting filtrate salinity, density, and neutron response. Now uses rmfs. Both bugs date to the initial commit (1b54d5e). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two latent bugs in
petropy/log.py, both present since the initial commit (1b54d5e):(d**2 + e) ** 0.2; the closed-form solution of the Simandoux quadratic requires a square root (** 0.5). With the fix, Simandoux correctly reduces to Archie when Vclay = 0 (verified numerically: 0.41667 == 0.41667; the old0.2produced 0.705). The matching docstring formula was corrected from a square to a square root.rws(formation-water surface resistivity) instead ofrmfs(mud-filtrate surface resistivity), corrupting filtrate salinity, density, and neutron response. Now usesrmfs.🤖 Generated with Claude Code