SID-116: Clean up twilio references in base sideburn pretix#54
Open
EastyMoryan wants to merge 2 commits into
Open
SID-116: Clean up twilio references in base sideburn pretix#54EastyMoryan wants to merge 2 commits into
EastyMoryan wants to merge 2 commits into
Conversation
EastyMoryan
commented
Jun 15, 2026
|
|
||
| customer, phone, sms_opt_in = _get_customer_and_phone(entry) | ||
|
|
||
| if not sms_opt_in: |
Author
There was a problem hiding this comment.
If a customer lacks a phone number or has opted out, we skip texting them. Previously, we queued the job and skipped execution. Now, we skip queuing altogether. We still also skip at execution, as a safeguard.
EastyMoryan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using more signals/receivers to standardize the Twilio plugin.
Despite adding a bit more infrastructure to src/pretix, using signals/receivers should make upgrading pretix versions easier and less prone to invisible errors.